Convert ndarray to scalar to avoid deprecation warning #7375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ricardoV94
reviewed
Jun 19, 2024
| @@ -115,6 +115,8 @@ def record(self, point, sampler_stats=None) -> None: | |||
| if sampler_stats is not None: | |||
| for data, vars in zip(self._stats, sampler_stats): | |||
| for key, val in vars.items(): | |||
| if isinstance(val, np.ndarray) and val.ndim > 0: | |||
There was a problem hiding this comment.
Is the val always a single number?
There was a problem hiding this comment.
Right, currently val is converted to a scalar only when it is a single-element ndarray
I think the correct implementation would be
if isinstance(val, np.ndarray):
# Extract the first element using indexing (preserves order)
val = val.flat[0]
data[key][self.draw_idx] = val
There was a problem hiding this comment.
I'm not sure these records are supposed to always be single elements. If not, discarding the rest doesn't make sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a Numpy deprecation warning by converting ndarray values to scalars in the record method.
Changes-
Updated record method to convert ndarray to scalar using val.item() before assignment.
Reason-
Prevents future errors due to deprecated implicit array-to-scalar conversions in Numpy.
Related Issue
test_metropolis.py#7369Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7375.org.readthedocs.build/en/7375/